Hardening: explicitly set shell=False on all subprocess.run() calls in fm11rf08s_recovery.py.

All four call sites already pass `cmd` as a Python list, so Python's default of `shell=False` means there is no active command-injection risk. This change makes the security intent explicit, prevents accidental future regression if a call site is later changed to pass a string, and improves code clarity.

No functional behaviour is changed.
This commit is contained in:
orbisai0security authored and Philippe Teuwen committed 2026-06-02 17:12:31 +02:00
1 parent ea142febde
commit 94c0fc2edd
1 file changed
+4 -4
+4 -4
View File
@@ -279,12 +279,12 @@ def recovery(init_check=False, final_check=False, keep=False, no_oob=False,
nt[sec][key_type], nt_enc[sec][key_type], par_err[sec][key_type]]
if debug:
print(' '.join(cmd))
subprocess.run(cmd, capture_output=True)
subprocess.run(cmd, capture_output=True, shell=False)
cmd = [staticnested_2x1nt_path,
f"keys_{uid:08x}_{real_sec:02}_{nt[sec][0]}.dic", f"keys_{uid:08x}_{real_sec:02}_{nt[sec][1]}.dic"]
if debug:
print(' '.join(cmd))
subprocess.run(cmd, capture_output=True)
subprocess.run(cmd, capture_output=True, shell=False)
filtered_dicts[sec][key_type] = True
for key_type in [0, 1]:
keys_set = set()
@@ -300,7 +300,7 @@ def recovery(init_check=False, final_check=False, keep=False, no_oob=False,
f"keys_{uid:08x}_{real_sec:02}_{nt[sec][key_type]}_filtered.dic"]
if debug:
print(' '.join(cmd))
result = subprocess.run(cmd, capture_output=True, text=True).stdout
result = subprocess.run(cmd, capture_output=True, text=True, shell=False).stdout
keys_def_set = set()
for line in result.split('\n'):
matched = match_key(line)
@@ -332,7 +332,7 @@ def recovery(init_check=False, final_check=False, keep=False, no_oob=False,
nt[sec][key_type], nt_enc[sec][key_type], par_err[sec][key_type]]
if debug:
print(' '.join(cmd))
subprocess.run(cmd, capture_output=True)
subprocess.run(cmd, capture_output=True, shell=False)
keys_set = set()
with (open(f"keys_{uid:08x}_{real_sec:02}_{nt[sec][key_type]}.dic")) as f:
while line := f.readline().rstrip():