Merge pull request #844 from paulfantom/hostpid

node-exporter: do not mount /proc as it is covered by hostPID

jsonnet/kube-prometheus/node-exporter/node-exporter.libsonnet

@@ -68,7 +68,6 @@
         image: $._config.imageRepos.nodeExporter + ':' + $._config.versions.nodeExporter,
         args: [
           '--web.listen-address=' + std.join(':', [$._config.nodeExporter.listenAddress, std.toString($._config.nodeExporter.port)]),
-          '--path.procfs=/host/proc',
           '--path.sysfs=/host/sys',
           '--path.rootfs=/host/root',
           '--no-collector.wifi',
@@ -76,7 +75,6 @@
           '--collector.filesystem.ignored-mount-points=^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/pods/.+)($|/)',
         ],
         volumeMounts: [
-          { name: 'proc', mountPath: '/host/proc', mountPropagation: 'HostToContainer', readOnly: true },
           { name: 'sys', mountPath: '/host/sys', mountPropagation: 'HostToContainer', readOnly: true },
           { name: 'root', mountPath: '/host/root', mountPropagation: 'HostToContainer', readOnly: true },
         ],
@@ -137,7 +135,6 @@
               }],
               containers: [nodeExporter, proxy],
               volumes: [
-                { name: 'proc', hostPath: { path: '/proc' } },
                 { name: 'sys', hostPath: { path: '/sys' } },
                 { name: 'root', hostPath: { path: '/' } },
               ],

manifests/node-exporter-daemonset.yaml

@@ -25,7 +25,6 @@ spec:
       containers:
       - args:
         - --web.listen-address=127.0.0.1:9100
-        - --path.procfs=/host/proc
         - --path.sysfs=/host/sys
         - --path.rootfs=/host/root
         - --no-collector.wifi
@@ -41,10 +40,6 @@ spec:
             cpu: 102m
             memory: 180Mi
         volumeMounts:
-        - mountPath: /host/proc
-          mountPropagation: HostToContainer
-          name: proc
-          readOnly: true
         - mountPath: /host/sys
           mountPropagation: HostToContainer
           name: sys
@@ -91,9 +86,6 @@ spec:
       tolerations:
       - operator: Exists
       volumes:
-      - hostPath:
-          path: /proc
-        name: proc
       - hostPath:
           path: /sys
         name: sys