An I2S bug in core ESP8266 Arduino was causing the square wave to fail,
not an I2S DAC problem. Move back to the square wave and save some
PROGMEM space and make it simpler and faster.
Seems like I2S DACs don't like to be presented with perfect bang-bang
square waveforms, so build a very simple model and use that to avoid
abrupt changes in values. Sounds about as good as you're going to get
with this.
Also add a simple example showing how to play a RTTTL string.
Hans-J. Ubben found a bug where the pinout wasn't being set properly on
ESP32s because the builtInDAC member was not set before calling SetPinout.
Fix per his suggestion.
The ID3 reader was incorrectly skipping extended headers and was
cutting off the last 10 bytes of the last ID3 entry. Correct per
http://id3.org specs.
Fixes#41
With the multiple I2S modes on the ESP32, it makes sense to use a
cleaner class hierarchy for the I2S tools. Make I2SNoDAC into a
subclass of I2S (renamed from I2SDAC) and remove about 80% of the
code which was identical exept for the per-sample bitstream synthesis.
To avoid allocations in the application, preallocate all decoder and
buffer memory in and then never free it. Use the new pre-alloc'd
constructors to generate the playback objects.
Because we are allocating objects totaling over 80% of the ESP8266 memory
space, we are very sensitive to memory fragmentation. While we can control
our own allocs, the IP and SDK can allocate any size, at any time, which
can cause us to not be able to find the large contiguous memory areas we need
for the codes.
Work around this by preallocating, before anything else, buffer memory and
never freeing it. Pass this memory into the codec and it will allocate from
this block and be guaranteed to always succeed.
This may fix the last of the hangs on the webradio/http streaming, which only
seemed to happen after a stop/start cycle.
Check for NULL input data buffers and set values to NULL after freeing()
local variables to avoid memory corruption on use-after-freee.
Add lots of error injection in the host testing to help find bugs on
the PC where they're easier to debug.
Check for NULL input data buffers and set values to NULL after freeing()
local variables to avoid memory corruption on use-after-freee.
Add lots of error injection in the host testing to help find bugs on
the PC where they're easier to debug.
When the input file(stream) doesn't open, you could end up calling
mp3::stop() which would try and mad_finish structures that were
not yet initialized. Now carry a flag when these are set, and only
_finish when it's set.
Valgrind found another uninitialized use. BitsPerSample was not being
called by the LIBMAD decoder, so it was possible to start out in a bad
state. Now always set it to 16, the decoder native output size.
Channels are initialized to 2, but this setting is always reset on
a per-frame basis anyway.
We removed the MP2-layer I and II decoders to save space, but an occasional
bad frame can come in that, by random chance, specifies one of this type.
Was calling NULL because of that. Now, just skip the frame and no crash.