Simplified argocd helm chart configuration

kubernetes/configuration.auto.tfvars.example

@@ -8,9 +8,25 @@ cilium_load_balancer_ip_range_start = "192.168.10.95"
 cilium_load_balancer_ip_range_stop = "192.168.10.99"
 
 # ArgoCD
-argocd_domain          = "argocd.local"
-argocd_server_insecure = true
-argocd_ingress_enabled = true
+argocd_helm_values = [
+    {
+      name  = "global.domain"
+      value = "argocd.local"
+    },
+    {
+      # See: https://argo-cd.readthedocs.io/en/stable/operator-manual/tls/#configuring-tls-for-argocd-server
+      name  = "configs.params.server\\.insecure"
+      value = "true"
+    },
+    {
+      name  = "server.ingress.enabled"
+      value = "true"
+    },
+    {
+      name  = "server.ingress.ingressClassName"
+      value = "cilium"
+    },
+]
 
 ## App of Apps
 install_argocd_app_of_apps                 = false

kubernetes/helm_releases.tf

@@ -6,7 +6,7 @@ resource "helm_release" "argocd" {
   repository = "https://argoproj.github.io/argo-helm"
   namespace  = kubernetes_namespace_v1.argocd.id
   timeout    = 120
-  set        = local.argocd_values
+  set        = var.argocd_helm_values
 }
 
 resource "helm_release" "cilium_lb_config" {

kubernetes/locals.tf

@@ -1,27 +0,0 @@
-locals {
-  argocd_values = concat(
-    [
-      {
-        name  = "global.domain"
-        value = var.argocd_domain
-      },
-    ],
-    var.argocd_server_insecure ? [
-      {
-        name  = "configs.params.server\\.insecure"
-        value = "true"
-      },
-    ] : [],
-    var.argocd_ingress_enabled ? [
-      {
-        name  = "server.ingress.enabled"
-        value = "true"
-      },
-      {
-        name  = "server.ingress.ingressClassName"
-        value = "cilium"
-      },
-    ] : [],
-    length(var.argocd_helm_values) > 0 ? var.argocd_helm_values : []
-  )
-}

kubernetes/variables.tf

@@ -26,31 +26,31 @@ variable "cilium_load_balancer_ip_range_stop" {
   type        = string
 }
 
-variable "argocd_domain" {
-  description = "The FQDN for ArgoCD application"
-  type        = string
-}
-
-# See: https://argo-cd.readthedocs.io/en/stable/operator-manual/tls/#configuring-tls-for-argocd-server
-variable "argocd_server_insecure" {
-  description = "Flag for disabling internal TLS with --insecure in ArgoCD Helm chart"
-  type        = bool
-  default     = true
-}
-
-variable "argocd_ingress_enabled" {
-  description = "Flag for enabling/disabling creating an Ingress in ArgoCD Helm chart"
-  type        = bool
-  default     = true
-}
-
 variable "argocd_helm_values" {
   description = "Additional Helm values for installing the ArgoCD Helm chart"
   type = list(object({
     name  = string
     value = string
   }))
-  default = []
+  default = [
+    {
+      name  = "global.domain"
+      value = "argocd.local"
+    },
+    {
+      # See: https://argo-cd.readthedocs.io/en/stable/operator-manual/tls/#configuring-tls-for-argocd-server
+      name  = "configs.params.server\\.insecure"
+      value = "true"
+    },
+    {
+      name  = "server.ingress.enabled"
+      value = "true"
+    },
+    {
+      name  = "server.ingress.ingressClassName"
+      value = "cilium"
+    },
+  ]
 }
 
 # See: https://argo-cd.readthedocs.io/en/latest/operator-manual/cluster-bootstrapping/#app-of-apps-pattern