Commit Graph
72 Commits
Author SHA1 Message Date
Travis Weathers cce14d43e3 fix(client): stop the Indala demod printing a debug line at INFO level
detectindala() reports the bit count it gave up on through
PrintAndLogEx(INFO, ...), so every failed Indala demodulation prints

  [=] DEBUG: detectindala | 56

in normal output. It is the failure path: found_size < 64 means the
demodulator did not find a valid Indala (64 or 224 bits) and is returning
-5. Any noisy LF read hits it, so `lf search` with no card on the antenna
shows a developer's debug line to every user.

Every sibling in the same function already uses DEBUG, including the one
nine lines above it at "DEBUG: Warning - Indala had to invert bits", so
this is an oversight rather than a deliberate level. ui.c drops DEBUG when
g_debugMode is 0, which is the default, so the line stays available under
`data setdebugmode -1` and is simply no longer in the way.

Checked the whole client for the same class: the only other "DEBUG"
strings printed above DEBUG level are cmddata.c FSKToNRZ, and both of
those are already wrapped in `if (g_debugMode > 1)`, so they are correct
and are left alone.

Before, `lf search` over a reader field with no card:

  [=] Checking for known tags...
  [=] DEBUG: detectindala | 56
  [-] No known 125/134 kHz tags found!

After:

  [=] Checking for known tags...
  [-] No known 125/134 kHz tags found!

and with `data setdebugmode -1` the detectindala lines come back, now
carrying the [#] debug prefix like the rest of them.

Passes `make style` unmodified.
2026-09-15 10:57:02 -04:00
Michael Wiesinger 737a6dc3d7 Fix help description for lf indala brute 2025-11-07 21:02:14 +01:00
iceman1001 79d1e102af style 2025-07-28 15:45:04 +02:00
Andy Shieh 7e7fe1837e [Fix] added original comments back; use same bitwise operation for even check
Signed-off-by: Andy Shieh <hsieandy@gmail.com>
2025-07-28 22:41:18 +10:00
Andy Shieh 9dd6e4a85f Fix getIndalaBits checksum logic
Signed-off-by: Andy Shieh <hsieandy@gmail.com>
2025-07-27 21:31:42 +10:00
iceman1001 2597c7576e style 2025-07-10 11:52:39 +02:00
iceman1001 ad292e8810 unify test - step 2 2025-03-25 10:17:42 +01:00
Philippe Teuwen ad84875afd cppcheck nullPointerOutOfMemory 2025-03-24 23:46:43 +01:00
iceman1001 4d603a4530 unify hint text 2025-03-20 22:55:26 +01:00
iceman1001 ff765f569f change out some non-breaking wait for response from some command which shouldnt have it. Sniff / simulate / bruteforce should have it. and some minor text / style 2024-10-04 10:01:50 +02:00
iceman1001 6a95f16102 style and text 2024-08-25 15:17:02 +02:00
mwalker33 e705c34247 Update cmdlfindala.c
cleanup
2024-08-17 13:49:22 +10:00
mwalker33 059b657156 Update cmdlfindala.c 2024-08-17 13:47:23 +10:00
mwalker33 20a0713441 Update cmdlfindala.c
25 But parity diz
2024-08-17 13:41:16 +10:00
Jacob Litewski f2afbca6ec Refactored Plot Annotations and some cleanup 2024-04-13 23:03:35 -04:00
iceman1001 c03e15b553 unify texts 2024-02-03 11:14:51 +01:00
iceman1001 efc8c0b8ab added a interactive flag for hf14asniff, and unified text across the project 2024-01-25 10:21:36 +01:00
iceman1001 fdc1c9d864 text 2023-12-06 22:16:53 +01:00
wh201906 3ee13c9ba6 Apply suggestions from @henrygab
Check if memory allocation fails
Fix memory leak
Initialize struct in declaration
Add/Fix some notes
Remove unlikely() in favor of readability
Remove a hard-coded magic number
2023-11-15 18:04:52 +08:00
wh201906 8b6a274e28 Bigger graph buffer
1280000 samples -> 10.24s for 125kHz 8bit sampling

Allocate graph related memory on heap
2023-11-14 10:05:13 +08:00
iceman1001 2b3d339714 lto missing inits 2023-08-02 17:46:53 +02:00
iceman1001 a9f81a05b4 text 2023-06-25 14:21:34 +02:00
Philippe Teuwen 951d6cd218 cppcheck uninitialized vars 2023-01-15 02:23:19 +01:00
iceman1001 d4b71a1774 modified lf indala sim to also accept facility code and card number 2022-10-30 16:29:50 +01:00
iceman1001 043fed0103 added lf indala brute command. Based on lf hid brute, can go up and down in cardnumbers 2022-10-30 08:54:13 +01:00
iceman1001 758e7d9d2b improve hf mf wrbl with text and a new param --force to make sure user understands when writing to block 0. 2022-03-24 12:30:48 +01:00
iceman1001 cdf079a0c1 less false positives with indala. Check ratio of zeros in demod. 2022-03-23 23:03:23 +01:00
Philippe Teuwen 623169fe02 fix some CodeQL warnings 2022-02-16 20:28:38 +01:00
Philippe Teuwen 30aa7aa7d1 Adapting license headers, WIP 2022-01-08 00:40:52 +01:00
Philippe Teuwen 7a5786b9e4 fix a number of strx usages 2022-01-01 02:39:10 +01:00
Philippe Teuwen 971c0126de cppcheck clarify mix of boolean and bitwise ops 2021-09-04 00:54:59 +02:00
Philippe Teuwen ce57637c80 rename globals GraphTraceLen OddByteParity pm3_capabilities 2021-08-21 17:53:54 +02:00
Philippe Teuwen f1f2389fb4 rename globals GraphBuffer 2021-08-21 17:39:17 +02:00
Philippe Teuwen e4fbfe0f40 rename globals DemodBuffer and DemodBufferLen 2021-08-21 17:12:50 +02:00
iceman1001 d992ce73c3 re-added the old checksum bits but guarded them as debug prints 2021-08-04 18:25:23 +02:00
merlokk 0204714f7e make style 2021-07-20 23:41:25 +03:00
iceman1001 e5fc1d83b2 use partiy.h and textual 2021-07-14 15:01:01 +02:00
Matthew Saunier 3160d99b7f Removed comments 2021-06-08 12:22:45 -06:00
Matthew Saunier 0b487c1fa7 Added 4041X permutation table in comments 2021-06-07 14:37:05 -06:00
Matthew Saunier 42f1124476 Restored original function and added 4041X as an optional format 2021-06-07 14:24:17 -06:00
Matthew Saunier d768869569 Rewrote getIndalaBits()
getIndalaBits() was not producing valid card data, examined a batch of genuine HID 4041X format cards and fixed up the transform from H10301 to 4041X. Now a read / clone using the same FC and SN will produce an identical card.
2021-06-04 10:27:10 -06:00
iceman1001 656231acba fix cppchecker knownconditiontrueorfalse 2021-05-07 10:16:29 +02:00
iceman1001 62d84dd734 text 2021-04-25 11:57:28 +02:00
iceman1001 72e5b9e80d text 2021-04-16 08:09:11 +02:00
Anže Jenšterle cd36770c5e make style 2021-02-09 16:56:55 +01:00
iceman1001 3a051b3266 lf indala sim - now it works again 2021-01-31 01:09:27 +01:00
Philippe Teuwen 7cd80611d3 #makestyleday 2020-12-12 14:46:40 +01:00
iceman1001 697463fb69 text 2020-12-04 23:38:40 +01:00
iceman1001 4bde614006 text 2020-12-04 23:32:47 +01:00
iceman1001 54e7f8d438 ... 2020-12-02 17:13:42 +01:00