From 1eae2e2d34cd0542e2e3a6dfaa810edebc4d9f87 Mon Sep 17 00:00:00 2001 From: iceman1001 Date: Tue, 10 Nov 2026 12:00:32 +0700 Subject: [PATCH] hf mf view: clear the RKF TCAS padding before comparing instances rkf_tcas_t has a padding byte before mac (offset 31). rkf_read_tcas() set every field but left that byte, and both the TCAS instance check in hf mf view and its selftest compare the two instances with memcmp. The result depended on stack contents: the Makefile client passed, the CMake client failed "tcas instances equal". Since 6fbe96e18 the CI greps the aggregate Transit selftest line, so every cmake test job (ubuntu, macos, wsl, proxspace) failed. Zero the whole struct in rkf_read_tcas(). Co-Authored-By: Claude Opus 5.5 --- client/src/parsers/parserkf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/client/src/parsers/parserkf.c b/client/src/parsers/parserkf.c index e45e72450..da4a1a9f9 100644 --- a/client/src/parsers/parserkf.c +++ b/client/src/parsers/parserkf.c @@ -817,6 +817,7 @@ static const char *rkf_log_slot(const rkf_tcas_t *t, uint8_t sector) { } static void rkf_read_tcas(const uint8_t *blk, rkf_tcas_t *t) { + memset(t, 0, sizeof(*t)); // padding too, instances are compared with memcmp t->identifier = (uint8_t)rkf_bits(blk, 0, 8); t->version = (uint8_t)rkf_bits(blk, 8, 6); for (uint8_t s = 0; s < RKF_SECTORS; s++) {