Fix a bunch of potential buffer overruns with CLIGetStrWithReturn :
Most prominent one was "lf pac clone --cn 123456789" causing garbage on the terminal Some changed code was valid before but as ppl tend to copy-paste to new code, better to uniformize and document usages of CLIGetStrWithReturn. Exceptions left are when filling real buffers (bin, raw,...), not strings.
This commit is contained in:
1 parent
78510f33a0
commit
153064ddfa
16 files changed
+31
-29
No files matched your search
@@ -1253,14 +1253,14 @@ static int CmdPCSC(const char *Cmd) {
|
||||
CLIExecWithReturn(ctx, Cmd, argtable, true);
|
||||
|
||||
uint8_t host[100] = {0};
|
||||
int hostLen = sizeof(host);
|
||||
int hostLen = sizeof(host) - 1; // CLIGetStrWithReturn does not guarantee string to be null-terminated
|
||||
CLIGetStrWithReturn(ctx, 1, host, &hostLen);
|
||||
if (hostLen == 0) {
|
||||
strcpy((char *) host, "localhost");
|
||||
}
|
||||
|
||||
uint8_t port[6] = {0};
|
||||
int portLen = sizeof(port);
|
||||
int portLen = sizeof(port) - 1; // CLIGetStrWithReturn does not guarantee string to be null-terminated
|
||||
CLIGetStrWithReturn(ctx, 2, port, &portLen);
|
||||
if (portLen == 0) {
|
||||
strcpy((char *) port, "35963");
|
||||
|
||||
Reference in new issue
Block a user