Fix a bunch of potential buffer overruns with CLIGetStrWithReturn :
Most prominent one was "lf pac clone --cn 123456789" causing garbage on the terminal Some changed code was valid before but as ppl tend to copy-paste to new code, better to uniformize and document usages of CLIGetStrWithReturn. Exceptions left are when filling real buffers (bin, raw,...), not strings.
This commit is contained in:
1 parent
78510f33a0
commit
153064ddfa
16 files changed
+31
-29
No files matched your search
+2
-2
@@ -272,12 +272,12 @@ int CmdLFCommandRead(const char *Cmd) {
|
||||
CLIExecWithReturn(ctx, Cmd, argtable, false);
|
||||
uint32_t delay = arg_get_u32_def(ctx, 1, 0);
|
||||
|
||||
int cmd_len = 128;
|
||||
char cmd[128] = {0};
|
||||
int cmd_len = sizeof(cmd) - 1; // CLIGetStrWithReturn does not guarantee string to be null-terminated
|
||||
CLIGetStrWithReturn(ctx, 2, (uint8_t *)cmd, &cmd_len);
|
||||
|
||||
int extra_arg_len = 250;
|
||||
char extra_arg[250] = {0};
|
||||
int extra_arg_len = sizeof(extra_arg) - 1; // CLIGetStrWithReturn does not guarantee string to be null-terminated
|
||||
CLIGetStrWithReturn(ctx, 3, (uint8_t *)extra_arg, &extra_arg_len);
|
||||
|
||||
uint16_t period_1 = arg_get_u32_def(ctx, 4, 0);
|
||||
|
||||
Reference in new issue
Block a user