Fix a bunch of potential buffer overruns with CLIGetStrWithReturn :
Most prominent one was "lf pac clone --cn 123456789" causing garbage on the terminal Some changed code was valid before but as ppl tend to copy-paste to new code, better to uniformize and document usages of CLIGetStrWithReturn. Exceptions left are when filling real buffers (bin, raw,...), not strings.
This commit is contained in:
1 parent
78510f33a0
commit
153064ddfa
16 files changed
+31
-29
No files matched your search
@@ -1025,8 +1025,8 @@ static int CmdAnalyseFoo(const char *Cmd) {
|
||||
uint8_t data[256];
|
||||
CLIGetHexWithReturn(ctx, 1, data, &datalen);
|
||||
|
||||
int data3len = 512;
|
||||
uint8_t data3[512];
|
||||
uint8_t data3[512] = {0};
|
||||
int data3len = sizeof(data3) - 1; // CLIGetStrWithReturn does not guarantee string to be null-terminated;
|
||||
CLIGetStrWithReturn(ctx, 1, data3, &data3len);
|
||||
|
||||
CLIParserFree(ctx);
|
||||
|
||||
Reference in new issue
Block a user