From a75e12deca75cdd2e373f64d72d5c57902a90470 Mon Sep 17 00:00:00 2001 From: QuantumEntangledAndy Date: Sat, 25 Jun 2022 07:18:00 +0700 Subject: [PATCH] Clippy --- crates/core/src/bc/ser.rs | 2 +- crates/core/src/bc_protocol.rs | 2 +- crates/core/src/bc_protocol/connection/bcconn.rs | 2 ++ crates/core/src/bc_protocol/connection/udpconn/transmit.rs | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/core/src/bc/ser.rs b/crates/core/src/bc/ser.rs index ee749cd..a56de4f 100644 --- a/crates/core/src/bc/ser.rs +++ b/crates/core/src/bc/ser.rs @@ -164,7 +164,7 @@ where { move |buf: WriteContext| { if let Some(ref val) = opt { - ser(&*val)(buf) + ser(val)(buf) } else { do_nothing()(buf) } diff --git a/crates/core/src/bc_protocol.rs b/crates/core/src/bc_protocol.rs index 40e099b..2fad5d3 100644 --- a/crates/core/src/bc_protocol.rs +++ b/crates/core/src/bc_protocol.rs @@ -31,7 +31,7 @@ pub use stream::{Stream, StreamOutput, StreamOutputError}; type Result = std::result::Result; -impl<'a> From for Error { +impl From for Error { fn from(k: std::sync::mpsc::RecvTimeoutError) -> Self { match k { std::sync::mpsc::RecvTimeoutError::Timeout => Error::Timeout, diff --git a/crates/core/src/bc_protocol/connection/bcconn.rs b/crates/core/src/bc_protocol/connection/bcconn.rs index 9d4e938..3efe3ce 100644 --- a/crates/core/src/bc_protocol/connection/bcconn.rs +++ b/crates/core/src/bc_protocol/connection/bcconn.rs @@ -96,6 +96,7 @@ impl BcConnection { Ok(()) } + #[allow(clippy::significant_drop_in_scrutinee)] pub fn subscribe(&self, msg_num: u16) -> Result { let (tx, rx) = channel(); match self.subscribers.lock().unwrap().entry(msg_num) { @@ -126,6 +127,7 @@ impl BcConnection { self.sink.lock().unwrap().is_udp() } + #[allow(clippy::significant_drop_in_scrutinee)] fn poll( context: &mut BcContext, connection: &BcSource, diff --git a/crates/core/src/bc_protocol/connection/udpconn/transmit.rs b/crates/core/src/bc_protocol/connection/udpconn/transmit.rs index 0125b86..37982f1 100644 --- a/crates/core/src/bc_protocol/connection/udpconn/transmit.rs +++ b/crates/core/src/bc_protocol/connection/udpconn/transmit.rs @@ -288,6 +288,7 @@ impl UdpTransmit { Ok(()) } + #[allow(clippy::significant_drop_in_scrutinee)] pub fn poll_write( &self, socket: &UdpSocket,