From ae89cad60d670eebbba0271c30774615e6e90f50 Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Tue, 14 Sep 2021 23:54:39 +0530 Subject: [PATCH 1/2] Made node-exporter args configurable Signed-off-by: Sahil Raja --- jsonnet/kube-prometheus/components/node-exporter.libsonnet | 1 + 1 file changed, 1 insertion(+) diff --git a/jsonnet/kube-prometheus/components/node-exporter.libsonnet b/jsonnet/kube-prometheus/components/node-exporter.libsonnet index 462e06b6..770407af 100644 --- a/jsonnet/kube-prometheus/components/node-exporter.libsonnet +++ b/jsonnet/kube-prometheus/components/node-exporter.libsonnet @@ -12,6 +12,7 @@ local defaults = { limits: { cpu: '250m', memory: '180Mi' }, }, listenAddress: '127.0.0.1', + filesystemIgnoredMountPoints: '^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/pods/.+)($|/)', port: 9100, commonLabels:: { 'app.kubernetes.io/name': defaults.name, From cbef68e0903c56d18742b01a1ee3f3d3be82569b Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Tue, 12 Oct 2021 09:01:45 +0530 Subject: [PATCH 2/2] Addressed review comments Signed-off-by: Sahil Raja --- jsonnet/kube-prometheus/components/node-exporter.libsonnet | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jsonnet/kube-prometheus/components/node-exporter.libsonnet b/jsonnet/kube-prometheus/components/node-exporter.libsonnet index 770407af..7a340593 100644 --- a/jsonnet/kube-prometheus/components/node-exporter.libsonnet +++ b/jsonnet/kube-prometheus/components/node-exporter.libsonnet @@ -12,7 +12,7 @@ local defaults = { limits: { cpu: '250m', memory: '180Mi' }, }, listenAddress: '127.0.0.1', - filesystemIgnoredMountPoints: '^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/pods/.+)($|/)', + filesystemMountPointsExclude: '^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/pods/.+)($|/)', port: 9100, commonLabels:: { 'app.kubernetes.io/name': defaults.name, @@ -181,7 +181,7 @@ function(params) { '--path.rootfs=/host/root', '--no-collector.wifi', '--no-collector.hwmon', - '--collector.filesystem.mount-points-exclude=^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/pods/.+)($|/)', + '--collector.filesystem.mount-points-exclude=' + ne._config.filesystemMountPointsExclude, // NOTE: ignore veth network interface associated with containers. // OVN renames veth.* to @if where X is /sys/class/net//ifindex // thus [a-z0-9] regex below