From 80b1e4643bd4962564ef96aedd0f718db159ed10 Mon Sep 17 00:00:00 2001
From: David Ventura <davidventura27@gmail.com>
Date: Tue, 7 May 2024 13:35:22 +0200
Subject: [PATCH] add test wifidetails + fix implementation offset

---
 impl.ts          |  2 +-
 tests/fn.test.js | 12 +++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/impl.ts b/impl.ts
index f53a800..e5f12ab 100644
--- a/impl.ts
+++ b/impl.ts
@@ -139,7 +139,7 @@ export const SendWifiDetails = (
   let m_dns2 = "0.0.0.0";
 
   // tag_wifiParams in types/all.h
-  cmd_payload.add(0x0b).writeU8(channel);
+  cmd_payload.add(0x0c).writeU8(channel);
   cmd_payload.add(0x10).writeU8(0); // TODO: AUTH
   cmd_payload.add(0x14).writeU8(1); // DHCP
   cmd_payload.add(0x18).writeByteArray(str2byte(ssid));
diff --git a/tests/fn.test.js b/tests/fn.test.js
index 82dc0ab..7d7d39c 100644
--- a/tests/fn.test.js
+++ b/tests/fn.test.js
@@ -3,6 +3,7 @@ import "../shim.ts";
 
 import assert from "assert";
 
+import { hexdump } from "../hexdump.js";
 import { XqBytesDec, XqBytesEnc } from "../func_replacements.js";
 import { makeP2pRdy, parseListWifi } from "../handlers.js";
 import { parse_PunchPkt, SendDevStatus, SendStartVideo, SendUsrChk, SendWifiDetails } from "../impl.ts";
@@ -259,7 +260,16 @@ describe("make packet", () => {
       "01010101"; // 0000
     const expected = hstrToBA(_expected_str);
 
-    const got = SendWifiDetails(sess, "skynet", "supercrap", true);
+    const got = SendWifiDetails(sess, "skynet", "supercrap", 0, true);
+    assert.deepEqual(got.buffer, expected);
+  });
+  it("builds a good WifiSettingsSet - with channel", () => {
+    const sess = { outgoingCommandId: 0xc, ticket: [0x30, 0x35, 0x74, 0x72] };
+    const _expected_str =
+      "f1d00118d100000c110a01600c010000303574720101010101010101030101010101010100010101404253422f4f445501010101010101010101010101010101010101010101010167606a6471607272010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101312f312f312f31010101010101010101312f3334342f3334342f333434010101312f312f312f31010101010101010101312f312f312f31010101010101010101312f312f312f3101010101010101010101010101";
+    const expected = hstrToBA(_expected_str);
+
+    const got = SendWifiDetails(sess, "ACRC.NET", "fakepass", 2, true);
     assert.deepEqual(got.buffer, expected);
   });
 });