From ebfb58c1fb5e9b141a72a27e9a9575a9674abbdf Mon Sep 17 00:00:00 2001 From: Alex Shepherd Date: Wed, 11 May 2016 20:53:06 +1200 Subject: [PATCH] Fixed issue reported by lucari Despite the values set for F0-4, a packet with all fields set to zero is received. The problem seems to be related to NrmaDcc.cpp and a hidden 'break' statement at line 484. This should be swapped with the #endif on the next line. The result is that when a Speed packet is processed, it drops through to the next case statement and sends an empty DCCFunc command. --- NmraDcc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NmraDcc.cpp b/NmraDcc.cpp index 6ecf53b..5a25826 100644 --- a/NmraDcc.cpp +++ b/NmraDcc.cpp @@ -481,8 +481,8 @@ void processMultiFunctionMessage( uint16_t Addr, DCC_ADDR_TYPE AddrType, uint8_t uint8_t fn0 = (Cmd & 0b00010000) ; notifyDccFunc( Addr, AddrType, FN_0, fn0 ) ; } - break; #endif + break; case 0b10000000: // Function Group 0..4 if( notifyDccFunc )