Fix for issue #474, and a few other bugs in MODGenerator (#478)

Fixes #474

This bug was already present in stellaplayer. Obviously "effectNumber" must be checked, because "effectParameterX" just holds the "upper nibble" of effectParameter

- do channel mixing in 32bit, to avoid noise from over/underflow
- write audio output as "signed int" (not unsigned)
- add int16 saturation check ("clipping")
* avoid crash when MOD file has to many CHANNELS
- avoid guru meditation, by logging an error and refusing playback in case MOD.numberOfChannels > CHANNELS
This commit is contained in:
Frank authored and GitHub committed 2022-01-05 08:25:26 -08:00
1 parent fe7a1f7951
commit c55d240ade
2 files changed
+42 -17

No files matched your search

+1 -1
View File
@@ -300,7 +300,7 @@ bool AudioOutputI2S::ConsumeSample(int16_t sample[2])
{
int16_t l = Amplify(ms[LEFTCHANNEL]) + 0x8000;
int16_t r = Amplify(ms[RIGHTCHANNEL]) + 0x8000;
s32 = (r << 16) | (l & 0xffff);
s32 = ((r & 0xffff) << 16) | (l & 0xffff);
}
else
{