From c0ec26169c9044edfca714f4d9845a5865cba3f3 Mon Sep 17 00:00:00 2001 From: "Earle F. Philhower, III" Date: Wed, 11 Jul 2018 16:00:05 -0700 Subject: [PATCH] Fix buffer overflow in ID3 decode When the ID3 tag had >64 bytes of data for an element, there was a 1-byte out of bounds access, causing a crash at some later point in time. Properly limit writes to the ID3 field buffer. Fixes #104 --- library.json | 2 +- library.properties | 2 +- src/AudioFileSourceID3.cpp | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/library.json b/library.json index 7e5fe22..5dd7a77 100644 --- a/library.json +++ b/library.json @@ -14,7 +14,7 @@ "type": "git", "url": "https://github.com/earlephilhower/ESP8266Audio" }, - "version": "1.1", + "version": "1.1.1", "homepage": "https://github.com/earlephilhower/ESP8266Audio", "frameworks": "Arduino", "examples": [ diff --git a/library.properties b/library.properties index 2301f86..9366757 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=ESP8266Audio -version=1.1 +version=1.1.1 author=Earle F. Philhower, III maintainer=Earle F. Philhower, III sentence=Audio file and I2S sound playing routines. diff --git a/src/AudioFileSourceID3.cpp b/src/AudioFileSourceID3.cpp index a90020a..1723b8d 100644 --- a/src/AudioFileSourceID3.cpp +++ b/src/AudioFileSourceID3.cpp @@ -218,12 +218,12 @@ uint32_t AudioFileSourceID3::read(void *data, uint32_t len) if (i