Reset errors and avoid memory leak (#321)

When reusing the AudioGeneratorMP3 object to play multiple files with errors, the error count was never reset.
Also, if 3 errors are encountered, it would stop running but never clean up the buffers.
This commit is contained in:
piebrain authored and GitHub committed 2020-10-26 18:54:37 -07:00
1 parent 299833dbf9
commit bbd8748f86
1 file changed
+5 -1
+5 -1
View File
@@ -231,7 +231,8 @@ retry:
audioLogger->printf_P(PSTR("MP3:ERROR_BUFLEN %d\n"), unrecoverable);
if (++unrecoverable >= 3) {
unrecoverable = 0;
return (running = false);
stop();
return running;
}
} else {
unrecoverable = 0;
@@ -269,6 +270,9 @@ bool AudioGeneratorMP3::begin(AudioFileSource *source, AudioOutput *output)
return false; // Error
}
// Reset error count from previous file
unrecoverable = 0;
output->SetBitsPerSample(16); // Constant for MP3 decoder
output->SetChannels(2);