From 81ebc8a11a60e4b38a6222cc47888827ba983095 Mon Sep 17 00:00:00 2001 From: "Earle F. Philhower, III" Date: Wed, 8 Oct 2025 17:01:58 -0700 Subject: [PATCH] Fix Talkie output on ESP32 (#774) Fixes #629 Need to set the I2S clock after begin() for ESP32 --- src/AudioGeneratorTalkie.cpp | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/src/AudioGeneratorTalkie.cpp b/src/AudioGeneratorTalkie.cpp index 7f1a704..da1ce8b 100644 --- a/src/AudioGeneratorTalkie.cpp +++ b/src/AudioGeneratorTalkie.cpp @@ -72,6 +72,21 @@ bool AudioGeneratorTalkie::begin(AudioFileSource *source, AudioOutput *output) { return false; } this->output = output; + + if (!output->SetBitsPerSample(16)) { + return false; + } + if (!output->SetChannels(2)) { + return false; + } + if (!output->begin()) { + return false; + } + if (!output->SetRate(8000)) { + return false; + } + + if (source) { file = source; if (!file->isOpen()) { @@ -95,20 +110,6 @@ bool AudioGeneratorTalkie::begin(AudioFileSource *source, AudioOutput *output) { running = false; } - if (!output->SetRate(8000)) { - return false; - } - if (!output->SetBitsPerSample(16)) { - return false; - } - if (!output->SetChannels(2)) { - return false; - } - if (!output->begin()) { - return false; - } - - return true; }